Various Clippy Fixes #526
Merged
Various Clippy Fixes #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`&str` implements `ToString` through a slower blanket impl, but `str` has a fast specialization of `ToString`
yoshuawuyts
reviewed
May 22, 2020
There was a problem hiding this comment.
Most of these look great! -- if we could revert the match blocks to how they were (9cfbea4) I think we're good!
yoshuawuyts
approved these changes
May 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This satisfies all off
clippy::allwith some fixes fromclippy::pedanticandclippy::nursery.Note: It's probably easier to review this per commit rather than as the whole diff as it has lots of little changes.